Skip to content

Scripts: Spell-check for windows #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2022
Merged

Scripts: Spell-check for windows #501

merged 3 commits into from
Sep 2, 2022

Conversation

marqdevx
Copy link
Member

What This PR Changes

  • Add spell-check for windows

@marqdevx marqdevx added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team labels Aug 23, 2022
@marqdevx marqdevx requested a review from sebromero August 23, 2022 08:58
@marqdevx marqdevx self-assigned this Aug 23, 2022
@marqdevx marqdevx force-pushed the marqdevx/scripts/spell-check-windows branch from 31d166d to c8c0831 Compare August 23, 2022 09:00
@marqdevx marqdevx marked this pull request as ready for review August 23, 2022 09:00
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 23, 2022 •
edited
Loading

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 4m

sebromero
sebromero requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to go :-)

@marqdevx @sebromero
Update scripts/spell-check.cmd
fb5ad6b 
Co-authored-by: Sebastian Romero <s.romero@arduino.cc>
@marqdevx marqdevx requested a review from sebromero August 23, 2022 10:10
sebromero
sebromero approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marqdevx marqdevx merged commit 57d3e42 into main Sep 2, 2022
@marqdevx marqdevx deleted the marqdevx/scripts/spell-check-windows branch September 2, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

Assignees

@marqdevx marqdevx

Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marqdevx @sebromero